Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43489 )
Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/Kconfig:
https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... PS1, Line 5: select GFX_GMA_IGNORE_PRESENCE_STRAPS if MAINBOARD_USE_LIBGFXINIT
This will need to be done for each mainboard that wants to use this option. […]
does it make sense to have that option selectable and not do anything? I'm not opposed to your solution, just wondering if we'd ever use it otherwise