Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )
Change subject: security/vboot/sync_ec: Add timestamps ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync... PS13, Line 159: timestamp_add_now(TS_EC_HASH_READY); Should we add it only when we return success? That will be consistent with other error scenarios where HASH_READY timestamp is not added?