Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39022 )
Change subject: soc/intel/apollolake: Make SMI_STS offset macro definition consistent
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/apollolake/include/soc/pm.h:
https://review.coreboot.org/c/coreboot/+/39022/comment/4cfa4658_fba0169f
PS2, Line 125: FAKE_PM1_SMI_STS
Looks like this bit was prefixed with `FAKE_` for a reason: `PM1_SMI_STS` is listed as reserved on APL/GLK. However, I understand that consistency is needed for a common implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3fbb459c106a3a58cd9a8b6eb3d7ee92e6ed82
Gerrit-Change-Number: 39022
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: V Sowmya
v.sowmya@intel.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 14:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment