Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25373 )
Change subject: sdm845: Add UART support
......................................................................
Patch Set 75:
(2 comments)
https://review.coreboot.org/#/c/25373/74/src/soc/qualcomm/sdm845/Kconfig
File src/soc/qualcomm/sdm845/Kconfig:
https://review.coreboot.org/#/c/25373/74/src/soc/qualcomm/sdm845/Kconfig@40
PS74, Line 40: default 9
Yes, 9 is the fixed QUP instance for console UART on SDM845 products.
Okay, in that case let's leave this here and remove it from cheza/Kconfig (so Cheza will just use this default). Other boards can still override it if necessary.
https://review.coreboot.org/#/c/25373/74/src/soc/qualcomm/sdm845/uart.c
File src/soc/qualcomm/sdm845/uart.c:
https://review.coreboot.org/#/c/25373/74/src/soc/qualcomm/sdm845/uart.c@146
PS74, Line 146: write32(®s->geni_m_cmd0, 0x08000000);
In UART protocol, we write 0x8000000 to the main engine to start TX transfers and the same to second […]
Sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25373
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827906e820bc15b7f60fdd7876a54c9ed36a48a1
Gerrit-Change-Number: 25373
Gerrit-PatchSet: 75
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 25 Jun 2019 00:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment