Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42348 )
Change subject: Revert "arch|cpu/x86: Add Kconfig option for x86 reset vector" ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
CP bootblock/soc/amd/picasso/memlayout.ld i386-elf-ld.bfd: _start16bit too low. Please report.
So it picks >cpu/x86/16bit/reset16.ld>. While correct, it means means the somewhat ugly X86_RESET_VECTOR, which as a literal constant for 20 odd years, now would need to be defined outside picasso too.
Can you drop <cpu/x86/entry16.ld> and <cpu/x86/reset16.ld> from the mentionded file instead?
Sure, I can take a look.
I haven't looked at the entire patch stack, but can't we put this section aligned to 16 bytes as the last thing. Then we can relocate adding to cbfs? It should all just work from there w/o manually specifying the location in the linker script.