Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36927 )
Change subject: mb/(i945): Remove redundant pci_mmio_size
......................................................................
Patch Set 1:
IIRC, the reasoning was that this way it is more visible where one could
change it [1]. I still have no strong opinion, so Arthur will have to
have one ;)
[1] https://review.coreboot.org/c/coreboot/+/16856/13..15#message-51978132245609...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36927
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50bf833383e8d06f73e05113cb92fdbbf39fdad6
Gerrit-Change-Number: 36927
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Nov 2019 09:17:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment