Attention is currently required from: Michael Niewöhner. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )
Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45273/comment/ab77a29e_8b910b0a PS8, Line 9: Generated 'build/dsdt.dsl' files for ibase/mb899 are identical.
they were not, what changed?
Thx a part of commit msg has gone. I'll fix it. It changes the binary as legacy compiler didn't the same optimization for "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)"
However, generated "dsdt.dsl" files are identical. the difference is in files comments: diff dsdt.dsl build/dsdt.dsl 8c8 < * Disassembly of build/dsdt.aml, Mon Jan 25 06:44:35 2021 ---
- Disassembly of build/dsdt.aml, Mon Jan 25 06:47:20 2021
12c12 < * Length 0x0000241C (9244) ---
Length 0x0000241A (9242)
14c14 < * Checksum 0xD7 ---
Checksum 0x51