[coreboot-gerrit] Change in ...coreboot[master]: vboot: standardize on working data size

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31474 )

Change subject: vboot: standardize on working data size
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31474/2/src/security/vboot/Kconfig 
File src/security/vboot/Kconfig:

https://review.coreboot.org/#/c/31474/2/src/security/vboot/Kconfig@95 
PS2, Line 95: VBOOT_WORKING_DATA_SIZE
> I believe Julius suggested that one option would be putting the constant we wish to use (VB2_WORKBUF_RECCOMEDED_SIZE) in a separate header file and including that header directly.  Would that be a preferable option?

Yeah that sounds like a good option -- especially because it ensures that we don't get out of sync with vboot. If it is too much work, we can go ahead with this config, but it would be good to at least add a comment in vboot indicating any firmware component relying on the value of VB2_WORKBUF_RECCOMEDED_SIZE should be updated any time vboot macro is updated.