1 Feb
2023
1 Feb
'23
6:09 p.m.
Attention is currently required from: Jérémy Compostella, Kapil Porwal, Paul Menzel, Julius Werner, Nick Vaccaro, Yu-Ping Wu.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72670 )
Change subject: commonlib: Add ELOG_TYPE_FW_EARLY_SOL eventLog type ......................................................................
Patch Set 8:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/elog.h:
https://review.coreboot.org/c/coreboot/+/72670/comment/10b2bd27_65af405f PS8, Line 368: #define ELOG_TYPE_FW_EARL
But now 0xb8 is not space out properly :(
they are all over the place in this file :D
--
To view, visit https://review.coreboot.org/c/coreboot/+/72670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bd5a250c0be824dbbad0236cee7d61a1ffdbc6c
Gerrit-Change-Number: 72670
Gerrit-PatchSet: 8
Gerrit-Owner: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 18:09:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-MessageType: comment