Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36754 )
Change subject: sb/intel/i82801gx: Add common early code ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36754/5/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/36754/5/src/southbridge/intel/i8280... PS5, Line 71: #if ENV_ROMSTAGE what's the harm in always having the function built (and gc'd by the linker)?