[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver

[Ran Bi (Code Review)]

Ran Bi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )

Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................

Patch Set 48:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46878/41/src/soc/mediatek/mt8192/pm... 
File src/soc/mediatek/mt8192/pmif.c:

https://review.coreboot.org/c/coreboot/+/46878/41/src/soc/mediatek/mt8192/pm... 
PS41, Line 12: #include <soc/srclken_rc.h>
> is this header necessary ?

MTK_SRCLKEN_RC_SUPPORT macro come from “soc/srclken_rc.h”. So we need to include this header.

https://review.coreboot.org/c/coreboot/+/46878/41/src/soc/mediatek/mt8192/rt... 
File src/soc/mediatek/mt8192/rtc.c:

https://review.coreboot.org/c/coreboot/+/46878/41/src/soc/mediatek/mt8192/rt... 
PS41, Line 5: #include <soc/clkbuf.h>
> remove ?

RTC need to operate some clockbuffer register like PMIC_RG_DCXO_CW02. So we need to include this header.