Attention is currently required from: Felix Singer, Henry Sun, Tarun Tuli, Yunlong Jia.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76013?usp=email )
Change subject: mb/google/nissa/var/gothrax: Initialise overridetree
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76013/comment/985a7b52_0320518d :
PS3, Line 168: probed
We see that some places use "detect" and "probed", so what is the difference between the two?
This can relief the OS burden of probing. But you need to take care the power sequence in gpio.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76013?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfd9788a75f9c342f85d6e1a3d54327d64797dd8
Gerrit-Change-Number: 76013
Gerrit-PatchSet: 6
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Comment-Date: Fri, 30 Jun 2023 09:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Comment-In-Reply-To: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-MessageType: comment