28 Aug
2024
28 Aug
'24
7:03 a.m.
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )
Change subject: soc/mediatek/mt8196: Add EINT support ......................................................................
Patch Set 8:
(1 comment)
File src/soc/mediatek/mt8196/eint.c:
https://review.coreboot.org/c/coreboot/+/84026/comment/91a29fe7_d51c480a?usp... : PS8, Line 11: [4]
The original struct is designed for kernel driver. […]
If we're using `uint8_t` for `instance`, please define enum for its values (e.g., `EINT_E`, `EINT_S`).
--
To view, visit https://review.coreboot.org/c/coreboot/+/84026?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibeb2dafcd9909b4afbfa81728700718f01d3818f
Gerrit-Change-Number: 84026
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Yidi Lin yidilin@google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 28 Aug 2024 07:03:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com