Attention is currently required from: Felix Singer, Damien Zammit, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: mb/hp/z220_series: Convert z220_sff_workstation into variant ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/mainboard/hp/z220_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/62808/comment/75c5dd54_a3d0bd79 PS2, Line 1: ## SPDX-License-Identifier: GPL-2.0-only Hmmm, this license header wasn't there before
File src/mainboard/hp/z220_series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62808/comment/d96b2810_bfc13196 PS2, Line 1: ## SPDX-License-Identifier: GPL-2.0-only Hmmm, this license header wasn't there before
File src/mainboard/hp/z220_series/variants/z220_sff_workstation/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62808/comment/b20fbec1_416de2d0 PS2, Line 5: subsystemid 0x103c 0x1791 inherit Is it necessary to specify the subsystemid here? It's in the devicetree already.