Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40570 )
Change subject: soc/intel/jasperlake: Add function to display ME firmware status info ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/in... File src/soc/intel/jasperlake/include/soc/me.h:
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/in... PS5, Line 21: invoke_enhance_dbg_mode: 1;
This is marked as reserved in the CSE BIOS specification document.
Ack
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/in... PS5, Line 36: u32 reserved_7: 2; : u32 reserved_9: 2; : u32 resered_11: 3; : u32 resered_14: 16; : u32 reserved_30: 2;
If we are not planning to inspect the fields, why can't they be just one chunk of 25 reserved bits.
Done
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/me... File src/soc/intel/jasperlake/me.c:
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/me... PS5, Line 10: /* Host Firmware Status Register 2 */
Why can't all these firmware register definitions be moved to the me.h file? […]
Done