[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/pantherlake: Update Touch Controller UPD params

[Subrata Banik (Code Review)]

Attention is currently required from: Bora Guvendik, Cliff Huang, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Pranava Y N.

Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )

Change subject: soc/intel/pantherlake: Update Touch Controller UPD params
......................................................................

Patch Set 4:

(3 comments)

File src/soc/intel/pantherlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/85199/comment/682afe31_3fc9e9ae?usp... :
PS2, Line 564: ThcAssignment
> adding 'else' condition to set ThcAssignment to THC_NONE. […]

Acknowledged

File src/soc/intel/pantherlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/85199/comment/34ff344c_f8ff1b21?usp... :
PS3, Line 569: 	}
Just add a line break, I read this as an else if from the previous if case.

https://review.coreboot.org/c/coreboot/+/85199/comment/8d837441_ea4c11d6?usp... :
PS3, Line 563: if (is_devfn_enabled(PCI_DEVFN_THC0)) {
             : 		s_cfg->ThcAssignment[0] = THC_0;
             : 		s_cfg->ThcMode[0] = config->thc_mode[0];
             : 		s_cfg->ThcWakeOnTouch[0] = config->thc_wake_on_touch[0];
             : 	} else {
             : 		s_cfg->ThcAssignment[0] = THC_NONE;
             : 	}
             : 	if (is_devfn_enabled(PCI_DEVFN_THC1)) {
             : 		s_cfg->ThcAssignment[1] = THC_1;
             : 		s_cfg->ThcMode[1] = config->thc_mode[1];
             : 		s_cfg->ThcWakeOnTouch[1] = config->thc_wake_on_touch[1];
             : 	} else {
             : 		s_cfg->ThcAssignment[1] = THC_NONE;
             : 	}
             : }
> in the first condidion: !is_devfn_enabled(PCI_DEVFN_THC0) && is_devfn_enabled(PCI_DEVFN_THC01)), bot […]

Acknowledged