Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41069 )
Change subject: soc/amd/common/block/lpc: Add config options for eSPI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/Kconfig:
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp... PS1, Line 19: Select this option if mainboard uses eSPI instead of LPC (if supported
This sounds a bit like LPC and eSPI were mutually exclusive which they aren't. […]
Please see my comment5 on b/154445472.
The way this is handled in chromium coreboot tree is not really right. Picasso doesn't really require a special LPC driver. The only thing that is really required is the ability to identify if a resource belongs to LPC v/s eSPI. If we have to support both LPC and eSPI for Picasso using this driver, I think it should be possible. We should simply enable device types that can be used by mainboards to indicate LPC or eSPI rather than using generic device numbers differently.
Also, I don't really see mandolin adding anything under the LPC generic device in chromium coreboot tree. I think let's continue with this for now and when you are upstreaming support for Mandolin, I can work with you to update this.