Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41759 )
Change subject: soc/intel/tigerlake: Add Type-C IOM base address and size macro
......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41759/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41759/3//COMMIT_MSG@17
PS3, Line 17: EST=Built and booted on Volteer.
Hi Prashant, as you might know that issue was due to dependency TBT patches were not merged. […]
Thanks. When you are ready to move this patch out of WIP, please do update the TEST string with the tests that you have run. This helps our engineers when we're diagnosing failures, and also helps folks with less context about this domain determine whether the patch has had a decent level of testing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70d88ba318087f7acacd1ee84609c9db5b65f907
Gerrit-Change-Number: 41759
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Mon, 01 Jun 2020 20:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Gerrit-MessageType: comment