Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62670 )
Change subject: mb/google/guybrush: Enable DEBUG_SMI for non-serial firmware ......................................................................
mb/google/guybrush: Enable DEBUG_SMI for non-serial firmware
In order to copy the PSP verstage logs into x86 cbmem, we need to enable DEBUG_SMI. This will include the CBMEM console code in SMM. I only enable DEBUG_SMI when UART is disabled because SMM doesn't currently save/restore the UART registers. This will result in clearing the interrupt enable bits and makes it so you can no longer use the TTY.
BUG=b:221231786, b:217968734 BRANCH=guybrush TEST=Build serial and non serial firmware and verify DEBUG_SMI is set correctly.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I85a7933e8eb49ff920d00e43a494aaeab555ef3b --- M src/mainboard/google/guybrush/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/62670/1
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index ecec688..b2cba6e 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -13,6 +13,7 @@ select AMD_SOC_CONSOLE_UART select BOARD_ROMSIZE_KB_16384 select CONSOLE_CBMEM_DUMP_TO_UART if !CONSOLE_SERIAL + select DEBUG_SMI if !CONSOLE_SERIAL # TODO(b/217968734): Always enable select DISABLE_KEYBOARD_RESET_PIN select DISABLE_SPI_FLASH_ROM_SHARING select DRIVERS_ACPI_THERMAL_ZONE