Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Mathew King, Karthik Ramasubramanian, Karthikeyan Ramasubramanian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51543 )
Change subject: mb/google/guybrush: Add initial I2C configuration
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51543/comment/e4ce74e0_d19129e4
PS3, Line 60: .speed = I2C_SPEED_FAST,
Do we drop early_init for this? Will AM init all buses during coreboot?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67690fbd25639879a730260aaca4cddb5e47bbc7
Gerrit-Change-Number: 51543
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Fri, 19 Mar 2021 11:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment