Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32771 )
Change subject: post_code: add post code for critical CBFS failures
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32771/3/src/soc/intel/quark/romstage/fsp2_0....
File src/soc/intel/quark/romstage/fsp2_0.c:
https://review.coreboot.org/#/c/32771/3/src/soc/intel/quark/romstage/fsp2_0....
PS3, Line 120: die_with_post_code(POST_INVALID_CBFS,
The commit message doesn't state that you only touch one platform, so I assume you want to update al […]
@Martin
I'm fine if you don't update all occurrences, but you need to communicate why. In this case as there are to many of them and the help of the community and platform maintainers is needed.
If you document the post codes in Documentation and advertise the new feature on the mailing list, everybody can contribute and improve the situation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32771
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1c8b92889040f9acd6250f847db02626809a987
Gerrit-Change-Number: 32771
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jett Rink
jettrink@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 May 2019 17:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Comment-In-Reply-To: Keith Short
keithshort@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment