Attention is currently required from: Felix Singer, Jérémy Compostella, Shuo Liu.
yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83318?usp=email )
Change subject: soc/intel/common/systemagent: Improve systemagent ......................................................................
Patch Set 12:
(2 comments)
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/83318/comment/24513a34_acfc978a?usp... : PS7, Line 308: return;
maybe no need HAVE_MULTIPLE_DOMAINS and the below logic will work. […]
Removing the if statement causes reserving same address ranges multiple time, I guess it's ok but a bit confusing.
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/83318/comment/982e2428_6791c3ab?usp... : PS10, Line 146: value = ALIGN_DOWN(value, 1 * MiB);
Shouldn't the 1MB align down still be kept?
The original logic is kept in the `soc_systemagent_fixup_address()`, please see it at the bottom of systemagent_early.c.