Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42224 )
Change subject: soc/amd/common/blocks/gpio: Introduce gpio_get_bar
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42224/4/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42224/4/src/soc/amd/common/block/gp...
PS4, Line 86: uint16_t block_offset = GPIO_BLOCK_SIZE * (gpio_num / GPIO_PINS_PER_BLOCK);
is it worth changing this to a shift rather than a divide for performance?
I would hope the compiler converts these to shifts. The values are all power of two.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42224
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id24f71bebd2dc9f6243e049c9f387a66b6d1d0c9
Gerrit-Change-Number: 42224
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 17:02:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Peers
epeers@google.com
Gerrit-MessageType: comment