Attention is currently required from: Jeremy Soller, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56256 )
Change subject: src/soc/intel/*: Change legacy_8254_timer to CMOS option
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/hp/280_g2/cmos.default:
https://review.coreboot.org/c/coreboot/+/56256/comment/699eb061_570737db
PS4, Line 1: legacy_8254_timer=Disable
Why `Disable`? The default for this board is to enable 8254. Moreover, this file and cmos. […]
Ack
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/56256/comment/11ef151a_1b6e3f43
PS4, Line 346: 1
If you leave the Kconfig option as-is and use `CONFIG(USE_LEGACY_8254_TIMER)` as the argument for `f […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic82c7f25cdf6587de5c40f59441579cfc92ff2f1
Gerrit-Change-Number: 56256
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 13 Jul 2021 13:15:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment