Attention is currently required from: Hung-Te Lin, Jianjun Wang, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84113?usp=email )
Change subject: soc/mediatek/common/pcie: Add DEVTREE_CONST qualifier ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84113/comment/b4ac67fe_6666bfde?usp... : PS2, Line 12: src/soc/mediatek/common/pcie.c:104:26: error: assignment discards
When will this error show up? I mean, why didn't Jenkins build fail without this patch?
Maybe explain this like:
``` Currently pcie.c is built into ramstage only, where DEVTREE_CONST is an empty macro, so there's no problem with that. However, if we would like to include that file in pre-ramstage, then DEVTREE_CONST would be 'const', leading to the following build error:
... ```