Attention is currently required from: Nico Huber, Wonkyu Kim, Kyösti Mälkki.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60213 )
Change subject: [WIP] cpu/x86/lapic: Fix choice X2APIC_ONLY
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60213/comment/7682413b_a28317cd
PS2, Line 11: avoid entering a printk() and acquiring console_lock and
: dead-locking.
just to be clear, have you observed this happening before?
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/60213/comment/fee9dfb2_bcf507f3
PS2, Line 652: lapic_send_ipi(LAPIC_INT_ASSERT | LAPIC_DM_SMI, lapicid());
it looks like this is the only place we send IPI to self. WDYT about a different API for sending an IPI to self ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78070ae91e78c11c3e3aa225e5673d4667d6f7bb
Gerrit-Change-Number: 60213
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 22 Dec 2021 19:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment