Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd...
File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd...
PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY
: select BOOT_DEVICE_SUPPORTS_WRITES
Do you insist on moving these switches to SoC? I mean I can do it if you see it as absolutely nece […]
OK, thank you for the test. I will move these switches into SoC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee12a5d1781c869b20bc14a52ecbf23474caa3fd
Gerrit-Change-Number: 35594
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 25 Sep 2019 11:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment