[coreboot-gerrit] [XS] Change in coreboot[main]: cpu/x86: Support runtime page tables on APs

[Arthur Heymans (Code Review)]

Attention is currently required from: Benjamin Doron, Jérémy Compostella, Patrick Rudolph.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79864?usp=email )

Change subject: cpu/x86: Support runtime page tables on APs
......................................................................

Patch Set 1:

(1 comment)

File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/79864/comment/208c5a6f_f8c4e1ba :
PS1, Line 236: uint32_t
> should be uint64_t in case cbmem was installed >4GiB

In that case you need a below 4G trampoline pages before setting those above 4G pages. Maybe that could be done as part of a follow-up, that makes above 4G firmware working in general?