Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33512 )
Change subject: soc/intel/cannonlake: set use of legacy 8254 timer ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/Kconfig@320 PS1, Line 320: (SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE)
What is different on CNL/CML?
Done
https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/fsp_params.... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/fsp_params.... PS1, Line 248: params->Enable8254ClockGating = CONFIG_USE_LEGACY_8254_TIMER;
Clock gating disables things...
Done
https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/fsp_params.... PS1, Line 249: params->Enable8254ClockGatingOnS3 = CONFIG_USE_LEGACY_8254_TIMER;
This is likely not needed because SeaBIOS doesn't run on the resume path. […]
Done