Attention is currently required from: Felix Held, Felix Singer, Nico Huber, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76131?usp=email )
Change subject: acpi/acpi.h: Add MADT GIC structures ......................................................................
Patch Set 2:
(8 comments)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/76131/comment/7040fe50_bc2c5d53 : PS1, Line 756:
remove empty line
Done
https://review.coreboot.org/c/coreboot/+/76131/comment/757a8a99_8f7254ea : PS1, Line 767: parking_protocol_persion
typo: `parking_protocol_version`
Done
https://review.coreboot.org/c/coreboot/+/76131/comment/99e0c594_31b7895d : PS1, Line 781: MADT GICC
`acpi_madt_gicc_t`?
Done
https://review.coreboot.org/c/coreboot/+/76131/comment/bd67eb6e_5ec4d375 : PS1, Line 794: acpi_gicd_t
`acpi_madt_gicd_t` ?
Done
https://review.coreboot.org/c/coreboot/+/76131/comment/09b115d5_f1927405 : PS1, Line 816: apci_girc
two typos: `acpi_gicr`
Done
https://review.coreboot.org/c/coreboot/+/76131/comment/4ce65f29_980cf9d4 : PS1, Line 823: acpi_gicr_t
`acpi_madt_gicr_t`?
Done
https://review.coreboot.org/c/coreboot/+/76131/comment/472b71cd_999a1aa0 : PS1, Line 826: apci_gic_its
typo: `acpi_gic_its`
Done
https://review.coreboot.org/c/coreboot/+/76131/comment/e41291e0_c0cce9e2 : PS1, Line 834: acpi_gic_its_t
`acpi_madt_gic_its_t`?
Done