Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )
Change subject: security/vboot/sync_ec: Add timestamps ......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 75: TS_DONE_LOADING = 508, nit: If you clarify DONE_HASHING, you should clarify this one too (this is loading the firmware body)
https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 74: TS_START_HASH_BODY = 507, : TS_DONE_LOADING = 508, : TS_DONE_HASHING_FW_MAIN = 509,
Same thing as far as I understand it. I'll change START too.
Yes, but I liked "BODY" better as the terminology here tbh.
https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm... PS19, Line 199: { TS_END_HASH_BODY, "finished verifying body signature (RSA)" }, All these timestamps talk about "body" either change them all or none of them (I don't see why it needs changing). Note that all the vboot timestamps will normally be together so I think it should be clear enough what is meant with body hash here.