Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32459 )
Change subject: google/kukui: Support sound in boot process
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32459/2/src/mainboard/google/kukui/chromeos....
File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/#/c/32459/2/src/mainboard/google/kukui/chromeos....
PS2, Line 42: {GPIO_EN_SPK_AMP.id, ACTIVE_HIGH, -1, "Enable speaker"},
Please use "speaker enable" which has precedent in Gru. (We should probably define constants for all of these one of these days...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97655702dff402245326d2eff71fae0e336df9f5
Gerrit-Change-Number: 32459
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaxin Yu
jiaxin.yu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jiaxin Yu
jiaxin.yu@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 May 2019 21:34:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment