Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )
Change subject: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@7 PS7, Line 7: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad Maybe:
Increase I2C5 bus freq closer to 400 kHZ for trackpad
https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@9 PS7, Line 9: The current frequency is 367kHz. Please also add the problem.
The current I2C5 bus frequency is 367 kHZ, causing the trackpad not to work.
or: operating outside the trackpad specification
(I do not have access to the bug report.)
https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@10 PS7, Line 10: This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency Please break the long line after 75 characters.