build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: Fix bootsplash display code for optionroms ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/bootsplash... File src/device/oprom/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/bootsplash... PS1, Line 18: int oprom_set_bootsplash(unsigned char *framebuffer, u16 x_resolution, u16 y_resolution, u16 fb_resolution); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/bootsplash... File src/device/oprom/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/bootsplash... PS1, Line 27: if (!jpeg) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/bootsplash... PS1, Line 33: } adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/realmode/x... PS1, Line 374: if (ret == -1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/realmode/x... PS1, Line 377: printk(BIOS_WARNING, "VBE: Bootsplash could not be decoded. jpeg_decode returned %d.\n", ret); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/yabel/vbe.... File src/device/oprom/yabel/vbe.c:
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/yabel/vbe.... PS1, Line 752: if (ret == -1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/yabel/vbe.... PS1, Line 754: } else if (ret > 0){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/34537/1/src/device/oprom/yabel/vbe.... PS1, Line 755: DEBUG_PRINTF_VBE("VBE: Bootsplash could not be decoded. jpeg_decode returned %d.\n", ret); line over 96 characters