Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63206 )
Change subject: mb/dell/snb_ivb_workstations: Fix SMBIOS slot desc for PCH PCIe ports ......................................................................
mb/dell/snb_ivb_workstations: Fix SMBIOS slot desc for PCH PCIe ports
The PCH's PCIe ports do not support Gen3 speeds, only Gen1/Gen2.
Change-Id: I7df61af1953ec99000c6c501b017e553190a46b6 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/63206 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/overridetree.cb M src/mainboard/dell/snb_ivb_workstations/variants/precision_t1650/overridetree.cb 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/overridetree.cb b/src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/overridetree.cb index 30167f9..bfe453f 100644 --- a/src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/overridetree.cb +++ b/src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/overridetree.cb @@ -4,7 +4,7 @@ chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH register "sata_port_map" = "0x7" device pci 1c.4 on # PCIe Port #5 - smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthLong" "SLOT2" "SlotDataBusWidth4X" + smbios_slot_desc "SlotTypePciExpressGen2X16" "SlotLengthLong" "SLOT2" "SlotDataBusWidth4X" end device pci 1c.5 on end # PCIe Port #6 device pci 1c.6 on end # PCIe Port #7 diff --git a/src/mainboard/dell/snb_ivb_workstations/variants/precision_t1650/overridetree.cb b/src/mainboard/dell/snb_ivb_workstations/variants/precision_t1650/overridetree.cb index 9452279..81133ee 100644 --- a/src/mainboard/dell/snb_ivb_workstations/variants/precision_t1650/overridetree.cb +++ b/src/mainboard/dell/snb_ivb_workstations/variants/precision_t1650/overridetree.cb @@ -5,10 +5,10 @@ chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH register "sata_port_map" = "0xf" device pci 1c.2 on # PCIe Port #3 - smbios_slot_desc "SlotTypePciExpressGen3X1" "SlotLengthShort" "SLOT2" "SlotDataBusWidth1X" + smbios_slot_desc "SlotTypePciExpressGen2X1" "SlotLengthShort" "SLOT2" "SlotDataBusWidth1X" end device pci 1c.4 on # PCIe Port #5 - smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthLong" "SLOT4" "SlotDataBusWidth4X" + smbios_slot_desc "SlotTypePciExpressGen2X16" "SlotLengthLong" "SLOT4" "SlotDataBusWidth4X" end device pci 1c.5 on end # PCIe Port #6 device pci 1c.6 on end # PCIe Port #7