Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31979 )
Change subject: soc/nvidia/tegra{124,210}: Use 'halt()' already defined in <halt.h> ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Seems like jenkins flagged these with +1 even with the error present.
https://review.coreboot.org/#/c/31979/1/src/soc/nvidia/tegra124/lp0/tegra_lp... File src/soc/nvidia/tegra124/lp0/tegra_lp0_resume.c:
https://review.coreboot.org/#/c/31979/1/src/soc/nvidia/tegra124/lp0/tegra_lp... PS1, Line 267: static inline uint32_t read32(const void *addr) Follow-up, these should come from device/mmio.h
https://review.coreboot.org/#/c/31979/1/src/soc/nvidia/tegra210/lp0/tegra_lp... File src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c:
https://review.coreboot.org/#/c/31979/1/src/soc/nvidia/tegra210/lp0/tegra_lp... PS1, Line 431: static inline uint32_t read32(const void *addr) Same