Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48183 )
Change subject: soc/amd: factor out common AOAC device enable and status query functions ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48183/1/src/soc/amd/common/block/ao... File src/soc/amd/common/block/aoac/aoac.c:
https://review.coreboot.org/c/coreboot/+/48183/1/src/soc/amd/common/block/ao... PS1, Line 6: Is it worth a comment that the device isn't guaranteed to be enabled upon exit? And can use is_aoac_device_enabled() to determine if it's up?
https://review.coreboot.org/c/coreboot/+/48183/1/src/soc/amd/common/block/ao... PS1, Line 11: UART I'm not sure why picasso mentioned UART in the comment. Probably left over from some older change. It seems out of place here. For that matter, the entire "power on..." comment seems redundant in a function named power_on...(). Same below.