[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brox/jubilant: Modify start-up timing for WWAN RW101R-GL

[Ren Kuo (Code Review)]

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84413?usp=email )

Change subject: mb/google/brox/jubilant: Modify start-up timing for WWAN RW101R-GL
......................................................................

mb/google/brox/jubilant: Modify start-up timing for WWAN RW101R-GL

Modify start-up timing for WWAN RW101R-GL to follow spec:
PWR_EN
FCPO#
RESET#

BUG=b:349698817
BRANCH=None
TEST= Build firmware and verify on jubilant within RW101R-GL
      Measure the start-up timing sequence
      Check the LTE modem connection on OS

Change-Id: I7aa3e7a172143ff1cebea7f48bda45d4fb2c77f7
Signed-off-by: Ren Kuo 
---
M src/mainboard/google/brox/variants/jubilant/gpio.c
1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/84413/1

diff --git a/src/mainboard/google/brox/variants/jubilant/gpio.c b/src/mainboard/google/brox/variants/jubilant/gpio.c
index 7562b65..bd31a3b 100644
--- a/src/mainboard/google/brox/variants/jubilant/gpio.c
+++ b/src/mainboard/google/brox/variants/jubilant/gpio.c
@@ -16,8 +16,6 @@
    PAD_CFG_GPO(GPP_D7, 1, DEEP),
    /* GPP_D5 : SRCCLKREQ0_L ==> WWAN_SAR_ODL */
    PAD_CFG_GPO(GPP_D5, 1, DEEP),
-	/* GPP_F21 : [NF1: Reserved NF6: USB_C_GPP_F21] ==> WWAN_FCPO_L */
-	PAD_CFG_GPO(GPP_F21, 0, DEEP),
    /* GPP_S4 : SNDW2_CLK/DMIC_CLK_B0 ==> WWAN_WLAN_COEX1 */
    PAD_CFG_GPI(GPP_S4, NONE, DEEP),
    /* GPP_S5 : SNDW2_DATA/DMIC_CLK_B1 ==> WWAN_WLAN_COEX2 */
@@ -31,6 +29,8 @@
    PAD_CFG_GPO(GPP_A12, 1, DEEP),
    /* GPP_H23 : SRCCLKREQ5_L ==> WWAN_RST_L */
    PAD_CFG_GPO_LOCK(GPP_H23, 1, LOCK_CONFIG),
+	/* GPP_F21 : [NF1: Reserved NF6: USB_C_GPP_F21] ==> WWAN_FCPO_L */
+	PAD_CFG_GPO(GPP_F21, 1, DEEP),
    /* GPP_H19 : SRCCLKREQ4_L ==> SAR1_INT_L */
    PAD_CFG_GPI_APIC_LOCK(GPP_H19, NONE, LEVEL, NONE, LOCK_CONFIG),

@@ -112,13 +112,15 @@
 /* Early pad configuration in bootblock */
 static const struct pad_config early_gpio_table[] = {

-	/* GPP_H23 : SRCCLKREQ5_L ==> WWAN_RST_L */
-	PAD_CFG_GPO(GPP_H23, 0, DEEP),
    /*
     * GPP_A12 : [NF1: SATAXPCIE1 NF2: SATAGP1 NF4: SRCCLKREQ9B# NF6: USB_C_GPP_A12]
     *  ==> WWAN_PWR_EN
     */
    PAD_CFG_GPO(GPP_A12, 1, DEEP),
+	/* GPP_H23 : SRCCLKREQ5_L ==> WWAN_RST_L */
+	PAD_CFG_GPO(GPP_H23, 0, DEEP),
+	/* GPP_F21 : [NF1: Reserved NF6: USB_C_GPP_F21] ==> WWAN_FCPO_L */
+	PAD_CFG_GPO(GPP_F21, 1, DEEP),

/*
     * FP_RST_ODL comes out of reset as hi-z and does not have an external pull-down.