Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83864?usp=email )
Change subject: src: Log boot info before cse sync
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/83864/comment/dc68255e_0128de2d?usp... :
PS1, Line 1434: elog_add_vboot_info();
You can't just remove these from platform-independent files and move them into an Intel-only file, y […]
Yes, agree it should not be move to platform specific code. I missed to mark the changes `TEST only`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83864?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40abfe870d6b3302005b898efbc7ebcae42ed52c
Gerrit-Change-Number: 83864
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 15 Aug 2024 12:08:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org