Attention is currently required from: Subrata Banik.
Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85802?usp=email )
Change subject: mb/google/fatcat/var/fatcat: Change touchpad interrupt to edge trigger
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/85802/comment/ad99b7b4_6a621b29?usp... :
PS1, Line 443: EDGE_SINGLE
Does this not contradict with devicetree irq configuration ```ACPI_IRQ_WAKE_LEVEL_LOW```? […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85802?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida0dfe10963a979c5e977133149d97799a76e3b3
Gerrit-Change-Number: 85802
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 30 Dec 2024 10:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Pranava Y N
pranavayn@google.com