Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35604 )
Change subject: util/mb/google/hatch: update CRC calculation for correctness
......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
Patch Set 2:
(1 comment)
Ah, I see the discussion reference to https://docs.python.org/3/library/zlib.html
Please put this link in for context.
Link and minimal context added.
https://review.coreboot.org/c/coreboot/+/35604/2/util/mainboard/google/hatch...
File util/mainboard/google/hatch/kconfig.py:
https://review.coreboot.org/c/coreboot/+/35604/2/util/mainboard/google/hatch...
PS2, Line 68: .
I am not sure what the original intended rules are or how the 'correct' value is determined. […]
The second option (treat as unsigned) is what we've been doing in the manual process for v2 HWIDs, so that's what the code will automatically do now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92f9ce1ceb7450f90b89c94e0ace6f79a9419b42
Gerrit-Change-Number: 35604
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 15:40:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew McRae
amcrae@chromium.org
Gerrit-MessageType: comment