Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21658
Change subject: console/init.c: Don't fetch console loglevel from cmos in romstage ......................................................................
console/init.c: Don't fetch console loglevel from cmos in romstage
Runtime console loglevel is not supported in romstage and the get_option function has printk() in it which should not be used before hardware is initialized.
Change-Id: I2fbf9febd695b012b8b4f04019fba806ac3181cf Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/console/init.c 1 file changed, 4 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/21658/1
diff --git a/src/console/init.c b/src/console/init.c index c1565a4..be99565 100644 --- a/src/console/init.c +++ b/src/console/init.c @@ -39,21 +39,15 @@ return console_loglevel; }
-static inline void set_log_level(int new_level) -{ - if (CONSOLE_LEVEL_CONST) - return; - - console_loglevel = new_level; -} - static void init_log_level(void) { int debug_level = CONFIG_DEFAULT_CONSOLE_LOGLEVEL;
- get_option(&debug_level, "debug_level"); + if (CONSOLE_LEVEL_CONST) + return;
- set_log_level(debug_level); + get_option(&debug_level, "debug_level"); + console_loglevel = debug_level; }
int console_log_level(int msg_level)