Hello Furquan Shaikh, Caveh Jalali, Duncan Laurie, Daisuke Nojiri, Nick Vaccaro, Aaron Durbin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43313
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake: Move tco_configure to bootblock ......................................................................
soc/intel/tigerlake: Move tco_configure to bootblock
On ChromeOS systems with a serial-enabled BIOS and vboot writing a new firmware image to the Chrome EC, it was possible for the TCO watchdog timer to trip 2 times before tco_configure() was called in romstage. This caused an extra reboot of the system (at a rather inopportune time) and because the EC didn't perform a full reset, the system boots into recovery mode.
This patch moves the call to tco_configure() for Tiger Lake from romstage to bootblock, in order to make sure the TCO watchdog timer is halted before vboot_sync_ec() runs in romstage. It should be harmless to configure the TCO device earlier in the boot flow.
BUG=b:160272400 TEST=boot Volteer (to a non-recovery kernel!) with a freshly imaged EC
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: Iefdc2c861ab8b5fde7f736c04149be7de7b3ae0c --- M src/soc/intel/tigerlake/bootblock/bootblock.c M src/soc/intel/tigerlake/romstage/pch.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/43313/2