Attention is currently required from: David Wu, Kenneth Chan, Ren Kuo, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84413?usp=email )
Change subject: mb/google/brox/jubilant: Modify start-up timing for WWAN RW101R-GL
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84413/comment/2719acae_0a449e53?usp... :
PS1, Line 10: PWR_EN
: FCPO#
: RESET#
Yes.the WWAN module datasheet is in the b:349698817 […]
Can you please capture that in the commit message for future reference? The change LGTM otherwise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84413?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7aa3e7a172143ff1cebea7f48bda45d4fb2c77f7
Gerrit-Change-Number: 84413
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 19 Sep 2024 15:40:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com