Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43661 )
Change subject: mb/google/vilboz: Tune I2C bus 3 clock
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43661/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43661/1/src/mainboard/google/zork/v...
PS1, Line 31: .rise_time_ns = 184, /* 0 to 1.26v (1.8 * .7) */
Are the comment incorrect?
Dear Paul, we need delete these comment, these values are correct for Vilboz. Thanks a lot!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa9f0bce723f55a12fd2313788c995f8326e3e7d
Gerrit-Change-Number: 43661
Gerrit-PatchSet: 2
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jul 2020 10:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment