Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31983 )
Change subject: device/pci_device: Add generic subsystem programming logic
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31983/1/src/device/pci_device.c
File src/device/pci_device.c:
https://review.coreboot.org/#/c/31983/1/src/device/pci_device.c@746
PS1, Line 746: cap_offset = pci_find_capability(dev, PCI_CAP_ID_SSVID);
offset one i have fixed. […]
Exactly that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31983
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8aed6dac24517e93cd55d6bb3b254b7b4d950d3
Gerrit-Change-Number: 31983
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Mar 2019 09:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment