Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35471 )
Change subject: soc/mediatek/mt8183: Refactor DRAM init by bit fields API
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35471/9/src/include/device/mmio.h
File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35471/9/src/include/device/mmio.h@6...
PS9, Line 64: * - low_bit: lowest bit in the bit field.
nit: mention DEFINE_BIT() here as well?
https://review.coreboot.org/c/coreboot/+/35471/9/src/include/device/mmio.h@1...
PS9, Line 121: #define DEFINE_BIT(name, bit) DEFINE_BITFIELD(name, bit, bit)
Separate patch, please.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I327297dd10718fbef7275fe95c95d00d3ab6ac84
Gerrit-Change-Number: 35471
Gerrit-PatchSet: 9
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 23:21:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment