Attention is currently required from: Subrata Banik, Hima B Chilmakuru.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61722 )
Change subject: mb/google/brya: Enable GPIO PM dynamically based on cr50 FW version
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/61722/comment/db3d454d_9a04d06a
PS4, Line 46: config->gpio_pm[COMM_0] = 0;
isn't the default value is always zero unless overridden.
Yes, but this would override anything that sneaks into the overridetrees, that was my reasoning here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf333dc0f177e17cd03b36ec7e487fc33bde2b93
Gerrit-Change-Number: 61722
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Hima B Chilmakuru
hima.b.chilmakuru@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Hima B Chilmakuru
hima.b.chilmakuru@intel.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 20:32:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment