Attention is currently required from: Jason Nien, Martin L Roth, Martin Roth, Paul Menzel, Raul Rangel.
Tim Van Patten has posted comments on this change by Tim Van Patten. ( https://review.coreboot.org/c/coreboot/+/73300?usp=email )
Change subject: skyrim/devicetree.cb: Remove BT GPIO 10 ......................................................................
Patch Set 2:
(5 comments)
Patchset:
PS2: PTAL, based on MTK's comment about GPIO10:
After checking with our SA member, there is no usage for GPIO10 on the MT7921/MT7922 m.2 module. As a result, it won’t affect power on sequence to MT7921 BT
Commit Message:
https://review.coreboot.org/c/coreboot/+/73300/comment/e8e27f3c_59ec859c?usp... : PS1, Line 11:
Kernel changes are much cheaper and easier to make, since they don't require a full FW Qual across m […]
Resolving, since MTK has clarified that GPIO10 isn't used at all, making it safe to remove.
Please re-open if there are still concerns here.
https://review.coreboot.org/c/coreboot/+/73300/comment/415aaa7a_b39b3c4f?usp... : PS1, Line 14: TEST=Connect BT mouse/keyboard
At the time, kernel v5.15.
Re-verified on kernel v6.6.
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73300/comment/444ef8f4_44e470c4?usp... : PS1, Line 176: reset_gpio
How long do we need to assert the reset GPIO?
Based on MTK's comment that GPIO10 doesn't affect the power on sequence, we don't need to assert it at all.
https://review.coreboot.org/c/coreboot/+/73300/comment/86d0be33_da6d1606?usp... : PS1, Line 176: ACPI_GPIO_OUTPUT_ACTIVE_LOW
I think this needs to flip polarity now, since the [_ON](https://source.corp.google. […]
Based on MTK's comment that GPIO10 doesn't affect the power on sequence, we don't need to assert it at all.
Please re-open if I'm misunderstanding things.