Attention is currently required from: Ben Chuang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59429 )
Change subject: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59429/comment/f067f977_6d9b9717
PS1, Line 14:
could you add
`BUG=b:206014046`
here?
Patchset:
PS1:
Hi Tim, this patch is similar to CL#57632 | https://review.coreboot.org/c/coreboot/+/57632. […]
Thanks Ben, looks like we have b:206014046 for this
File src/drivers/genesyslogic/gl9750/gl9750.c:
https://review.coreboot.org/c/coreboot/+/59429/comment/da849708_dc61bcfa
PS1, Line 7: #include <device/path.h>
unused?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d60cef41baade7457a159d3ce2f8d2e6b66e71c
Gerrit-Change-Number: 59429
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Greg Tu
greg.tu@genesyslogic.com.tw
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ben Chuang
benchuanggli@gmail.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 16:40:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ben Chuang
benchuanggli@gmail.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment